Enable data area 4 internal-log ocp plugin command#2901
Enable data area 4 internal-log ocp plugin command#2901igaw merged 2 commits intolinux-nvme:masterfrom
Conversation
jeff-lien-sndk
force-pushed
the
enable-da4-ocp
branch
2 times, most recently
from
2800364 to
1ce97b7
Compare
The current ocp internal-log command will only retrieve up to data area 3. This change will enable retrieving of all 4 telemetry log data areas. It will also refactor the code used to save off the 2 files collected: telemetry log and string log along with the 1 generated file: the parsed da 1 and 2 data. Swap -o and -f on output-format and output-file parameters. Signed-off-by: jeff-lien-sndk <[email protected]> Reviewed-by: brandon-paupore-sndk <[email protected]>
The man page documentation has been updated to document the change of -o for output-format and -f for output-file. Also there have been updates made to note new supported data areas. Signed-off-by: jeff-lien-sndk <[email protected]> Reviewed-by: brandon-paupore-sndk <[email protected]>
jeff-lien-sndk
force-pushed
the
enable-da4-ocp
branch
from
1ce97b7 to
573b237
Compare
|
Looks good. I haven't checked but it might be necessary to update the tab completions for bash and zsh as well. |
|
@igaw What tab completions? I haven't done that in any previous PR's. |
|
I keep forgetting to ask to update the those files whenever a command gets new/changes arguments. In this case it would be this here: nvme-cli/completions/bash-nvme-completion.sh Line 1599 in a6d01ef Line 191 in a6d01ef |
| [--output-file=<file> | -o <file>] | ||
| [--output-format=<fmt> | -f <fmt>] | ||
| [--output-file=<file> | -f <file>] | ||
| [--output-format=<fmt> | -o <fmt>] |
There was a problem hiding this comment.
FYI this broke some test automation at my employer.
There was a problem hiding this comment.
FWIW, I recommend to use the long form version of arguments for automation. They tend to be way more stable.
Yes, we try to keep it stable but sometimes things just go wrong. Sorry.
There was a problem hiding this comment.
This change was made to make the -o and -f parameter options consistent with other nvme cli commands.
3 participants
The current ocp internal-log command will only retrieve up to data area 3. This change will enable retrieving of all 4 telemetry log data areas.
It will also refactor the code used to save off the 2 files collected: telemetry log and string log along with the 1 generated file: the parsed da 1 and 2 data.
Swap -o and -f on output-format and output-file parameters.